Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1725: KIE Tools: folder indicator is lost #2824

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

Kusuma04-dev
Copy link
Contributor

closes apache/incubator-kie-issues#1725 when user is uploading pdf file in the dmn editor , untitled folder is getting created but when user goes to home screen , folder is missing.
Before fix:
Screenshot 2024-12-20 at 8 16 26 PM

After fix:
Screenshot 2024-12-20 at 8 16 03 PM

@Kusuma04-dev Kusuma04-dev changed the title Kie issues#1725 BAMOE Canvas folder indicator is lost Kie issues#1725 folder is missing when user upload a file in the DMN editor Dec 20, 2024
@Kusuma04-dev Kusuma04-dev reopened this Dec 20, 2024
@kbowers-ibm kbowers-ibm changed the title Kie issues#1725 folder is missing when user upload a file in the DMN editor kie-issues#1725: KIE Tools: folder indicator is lost Dec 20, 2024
@kbowers-ibm kbowers-ibm self-requested a review December 20, 2024 15:22
Copy link
Contributor

@kbowers-ibm kbowers-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Kusuma!

@danielzhe danielzhe self-requested a review December 30, 2024 20:14
Copy link
Contributor

@danielzhe danielzhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not manual check. Screenshots looks good to me.

Copy link
Contributor

@ljmotta ljmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kusuma04-dev I've tested it locally, looks great. Thanks!

@ljmotta ljmotta merged commit fd78863 into apache:main Jan 2, 2025
24 of 29 checks passed
ljmotta pushed a commit to ljmotta/kie-tools that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KIE Tools: folder indicator is lost
5 participants